ergodox_ez: Matrix changes now used for debounce() #5589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Apr 9, 2019
|
Thanks! Can confirm it fixes the issue with Sym-G |
drashna
pushed a commit
to drashna/qmk_firmware
that referenced
this pull request
Apr 9, 2019
danielo515
pushed a commit
to danielo515/qmk_firmware
that referenced
this pull request
May 15, 2019
shimesaba-type0
pushed a commit
to shimesaba-type0/qmk_firmware
that referenced
this pull request
Jun 22, 2019
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ergodox_ez now calculates whether the matrix changed during scanning.
Description
Ergodox_ez previously did not calculate if the matrix changed while scanning it.
This is required to make sym_g debounce work correctly.
Types of Changes
Issues Fixed or Closed by This PR
Checklist
I have only compiled it - @drashna (lol) to test.