Replace DEBOUNCING_DELAY (depricated) with DEBOUNCE #5997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested review from
algernon,
jackhumbert,
yanfali,
skullydazed,
fredizzimo,
noroadsleft and
mechmerlin
fauxpark
approved these changes
May 27, 2019
s/depricated/deprecated 😆 |
|
@fauxpark actually, the breaking change has already occurred. But yes. @noroadsleft tomato, tomato. :D |
|
I'm using @skullydazed's definition of "breaking change", because this PR touches user keymaps. |
drashna
force-pushed
the
fix/debouncing_defines
branch
from
1e848d6
to
8f5d8d1
Compare
drashna
force-pushed
the
fix/debouncing_defines
branch
from
8f5d8d1
to
9d8277d
Compare
jackhumbert
approved these changes
Jun 5, 2019
|
Travis is running So there will be errors |
mechmerlin
approved these changes
Jun 6, 2019
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
writerbenjamin
added a commit
to writerbenjamin/qmk_firmware
that referenced
this pull request
Jul 13, 2019
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
swamp09
pushed a commit
to swamp09/qmk_firmware
that referenced
this pull request
Mar 11, 2020
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Like the title says.
Specifically,
DEBOUNCING_DELAYis no longer used by the core code, butDEBOUNCEis.This changes the defines everywhere to use
DEBOUNCE, so it's consistent everywhere.Types of Changes
Checklist