Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing effects to respect user sat and val levels #6275

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Fixing effects to respect user sat and val levels #6275

merged 1 commit into from
Jul 11, 2019

Conversation

XScorpion2
Copy link
Contributor

Description

Fixes color band rgb matrix effects that were not respecting the current saturation and value levels from the config.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin mechmerlin added the bug label Jul 8, 2019
@drashna
Copy link
Member

drashna commented Jul 11, 2019

Thanks!

@drashna drashna merged commit 3ee0622 into qmk:master Jul 11, 2019
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jul 12, 2019
@XScorpion2 @drashna
Fixing effects to respect user sat and val levels (qmk#6275)
7ac3bc5
@XScorpion2 XScorpion2 deleted the bugfix/rgb_matrix_effects branch July 16, 2019 01:22
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jul 16, 2019
@XScorpion2 @fdidron
Fixing effects to respect user sat and val levels (qmk#6275)
fd2246f
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@XScorpion2 @doughsay
Fixing effects to respect user sat and val levels (qmk#6275)
c947838
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
@XScorpion2 @drashna
Fixing effects to respect user sat and val levels (qmk#6275)
13acbc4
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@XScorpion2
Fixing effects to respect user sat and val levels (qmk#6275)
d94e576
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@XScorpion2 @drashna
Fixing effects to respect user sat and val levels (qmk#6275)
34d1ac6
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@XScorpion2 @swamp09
Fixing effects to respect user sat and val levels (qmk#6275)
347bf11
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@XScorpion2 @drashna
Fixing effects to respect user sat and val levels (qmk#6275)
3ff4750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XScorpion2 @drashna @zvecr @mechmerlin