Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Configurator support for snampad #6435

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 29, 2019

Description

QMK api error log (http://compile.qmk.fm/v1/keyboards/error_log) contains:

{
  "severity":"error",
  "message":"Error: Could not parse qmk_firmware/keyboards/snampad/info.json as JSON: Expecting value: line 1 column 1 (char 0)"
}

Tagging @ptillemans as maintainer.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Jul 29, 2019
@zvecr zvecr requested a review from a team July 29, 2019 14:22
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@drashna drashna merged commit a699fd3 into qmk:master Jul 30, 2019
raymond-w-ko pushed a commit to raymond-w-ko/qmk_firmware that referenced this pull request Aug 4, 2019
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@zvecr zvecr deleted the feature/snampad_fix branch April 28, 2020 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants