Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the older universal_newlines name instead of text #6506

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Use the older universal_newlines name instead of text #6506

merged 1 commit into from
Aug 7, 2019

Conversation

skullydazed
Copy link
Member

Description

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skullydazed skullydazed merged commit 3cb28bb into master Aug 7, 2019
@skullydazed skullydazed deleted the fix_compile_json branch August 7, 2019 19:00
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Aug 8, 2019
@skullydazed @drashna
Use the older universal_newlines name instead of text (qmk#6506)
0bb6615
@zvecr zvecr mentioned this pull request Aug 12, 2019
Closed
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Aug 13, 2019
@skullydazed @fdidron
Use the older universal_newlines name instead of text (qmk#6506)
9e38863
incredibleweirdo pushed a commit to electricbrainreserve/qmk_firmware that referenced this pull request Aug 15, 2019
@skullydazed @incredibleweirdo
Use the older universal_newlines name instead of text (qmk#6506)
920f510
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@skullydazed @doughsay
Use the older universal_newlines name instead of text (qmk#6506)
c787175
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
@skullydazed
Use the older universal_newlines name instead of text (qmk#6506)
90ab778
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@skullydazed
Use the older universal_newlines name instead of text (qmk#6506)
d71a3c1
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@skullydazed
Use the older universal_newlines name instead of text (qmk#6506)
141f928
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@skullydazed
Use the older universal_newlines name instead of text (qmk#6506)
219d804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qmk compile-json crashes with TypeError
2 participants
@skullydazed @zvecr