Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB Inidcator example for new van pcbs #6544

Merged
merged 2 commits into from
Aug 25, 2019
Merged

Conversation

jetpacktuxedo
Copy link
Contributor

@jetpacktuxedo jetpacktuxedo commented Aug 15, 2019

Description

Added rgb pin definitions for the minivan (hotswap pcbs have three top-facing rgb indicators on the top left) as well as added an example of usage in my personal keymap. I also dropped a bunch of commented-out and dead code from the minivan core files, and made a tiny change to my keymap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@jetpacktuxedo
Copy link
Contributor Author

Put together a little video demo:
https://youtu.be/ZvEv4ldNg1g

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@drashna drashna added the keymap label Aug 17, 2019
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mechmerlin mechmerlin merged commit c289a4c into qmk:master Aug 25, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Aug 27, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (42 commits)
  pegasushoof Specify the bootloader to use :flash (qmk#6614)
  Fix Typo in :flash target for missing bootloader (qmk#6615)
  Mars80 Bug: Physical/Electrical Matrix Mismatch (qmk#6612)
  [Keymap] Redox_w Use layer_state_set_user instead of matrix_scan_user (qmk#6608)
  Added OLED Display autoscroll during periods of OLED data inactivity (qmk#6546)
  Refactor `qmk compile-json` to `qmk compile` (qmk#6592)
  RGB Inidcator example for new van pcbs (qmk#6544)
  Add new 60% Tsangan HHKB layout (qmk#6607)
  [Keyboard] Maartenwut Wonderland PCB (qmk#6492)
  Add 2015 revision of Pegasus Hoof to QMK (qmk#6595)
  [Keyboard] New Keyboard: EVE Meteor (qmk#6565)
  updates the coc
  [Keymap] a keymap to "transform" a jj40 info a simil Alpha28, to enjoy its simplicity and power (qmk#6599)
  [Keyboard] Add JNAO keyboard (qmk#6598)
  [Keymap] ISO keymap for TADA68 with programming in mind (qmk#6597)
  [Keymap] Update to userspace kuchosauroand0 (qmk#6596)
  Add 'bootloadHID' flash target (qmk#5587)
  Add Zadig 101 to docs (qmk#6585)
  Add Soft Serial Speed to Diverge3 keyboard config for compatibility (qmk#5076)
  Added 4by3 keyboard (qmk#6547)
  ...
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
* RGB Inidcator example for new van pcbs

* simplify config.h

As per @drashna in CR
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
* RGB Inidcator example for new van pcbs

* simplify config.h

As per @drashna in CR
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
* RGB Inidcator example for new van pcbs

* simplify config.h

As per @drashna in CR
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
* RGB Inidcator example for new van pcbs

* simplify config.h

As per @drashna in CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants