Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 1ms polling rate #6700

Closed
wants to merge 1 commit into from
Closed

Use 1ms polling rate #6700

wants to merge 1 commit into from

Conversation

narze
Copy link
Contributor

@narze narze commented Sep 8, 2019

Description

Making use of USB_POLLING_INTERVAL_MS option that is just released.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark reviewed Sep 8, 2019
View reviewed changes
keyboards/ergodox_infinity/keymaps/narze/rules.mk
@@ -16,6 +10,7 @@ AUDIO_ENABLE = no # Audio output on port C6
UNICODE_ENABLE = no # Unicode
BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID
RGBLIGHT_ENABLE = no # Enable WS2812 RGB underlight.
USB_POLLING_INTERVAL_MS = 1 # 1000hz polling rate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes in your config.h, not rules.mk :)

@drashna
Copy link
Member

drashna commented Sep 8, 2019 •
edited
Loading

Honest, I'd rather see this ar part of #6694 rather than as a separate PR.

Specifically, because we kind of want to minimize the commit logs. It's also why we always squash keymap PRs.

@narze
Copy link
Contributor Author

narze commented Sep 8, 2019

Ok, I'll add it to #6694

@narze narze closed this Sep 8, 2019
@narze narze mentioned this pull request Sep 8, 2019
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narze @drashna @fauxpark