Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keymap] add halvves let's split keymap #7063

Merged
merged 6 commits into from
Oct 22, 2019
Merged

[keymap] add halvves let's split keymap #7063

merged 6 commits into from
Oct 22, 2019

Conversation

halvves
Copy link
Contributor

@halvves halvves commented Oct 17, 2019

Hey! Just finally taking the time to toss my keymap up in the repo. Thanks!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@halvves halvves changed the title add halvves let's split keymap [keymap] add halvves let's split keymap Oct 17, 2019
fauxpark
fauxpark requested changes Oct 18, 2019
View reviewed changes
keyboards/lets_split/keymaps/halvves/config.h Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/config.h Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/config.h Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team October 18, 2019 00:02
@halvves halvves requested review from fauxpark and removed request for a team October 18, 2019 17:22
fauxpark
fauxpark requested changes Oct 19, 2019
View reviewed changes
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
drashna
drashna requested changes Oct 19, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, for the most part.

The default layer functions could and probably should be replaced though.

keyboards/lets_split/keymaps/halvves/keymap.c Outdated Show resolved Hide resolved
@halvves halvves requested a review from drashna October 20, 2019 23:19
noroadsleft
noroadsleft approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

drashna
drashna approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!!

@drashna drashna merged commit 4b47abc into qmk:master Oct 22, 2019
@halvves halvves deleted the keymap/halvves branch October 23, 2019 16:55
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@halvves
[Keymap] add halvves let's split keymap (qmk#7063)
00c380e 
* add halvves let's split keymap

* [cr] - review requests from @fauxpark

* cleanup spacing, add transparent for spaces in util layer

* [cr] - use new core funcs / @fauxpark & @drashna

* enable EE_HANDS

* [cr] - switch to definable mask for layer state (@drashna)
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@halvves @HokieGeek
[Keymap] add halvves let's split keymap (qmk#7063)
bdd8270 
* add halvves let's split keymap

* [cr] - review requests from @fauxpark

* cleanup spacing, add transparent for spaces in util layer

* [cr] - use new core funcs / @fauxpark & @drashna

* enable EE_HANDS

* [cr] - switch to definable mask for layer state (@drashna)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@halvves @drashna @fauxpark @noroadsleft