Add hbcp #7101

hineybush · 2019-10-21T05:59:03Z

Description

Add initial hbcp files

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/hineybush/hbcp/config.h

keyboards/hineybush/hbcp/keymaps/default/keymap.c

yanfali · 2019-10-21T06:27:38Z

keyboards/hineybush/hbcp/keymaps/hiney/keymap.c

+
+}
+
+#ifdef RGBLIGHT_ENABLE


ditto for this, it's duplicate if you move it to keyboard.c

keyboards/hineybush/hbcp/rules.mk

yanfali · 2019-10-21T07:07:50Z

Generating info.json is pretty easy using raw kle. Just copy it into qmk.fm/converter once per layout you want to support and copy it to appropriate place. @noroadsleft can help out if you need it

yanfali

Looks good to me. @fauxpark you probably have some feedback on rules.mk

keyboards/hineybush/hbcp/hbcp.c

keyboards/hineybush/hbcp/readme.md

keyboards/hineybush/hbcp/rules.mk

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Co-Authored-By: Joel Challis <git@zvecr.com>

keyboards/hineybush/hbcp/rules.mk

keyboards/hineybush/hbcp/keymaps/hiney/keymap.c

keyboards/hineybush/hbcp/rules.mk

keyboards/hineybush/hbcp/hbcp.c

keyboards/hineybush/hbcp/info.json

keyboards/hineybush/hbcp/keymaps/hiney/keymap.c

keyboards/hineybush/hbcp/keymaps/hiney/readme.md

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

keyboards/hineybush/hbcp/info.json

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

drashna

Thanks!

noroadsleft

Spoke a bit too soon.

You deleted your color definitions from the hiney/keymap.c, but they never made it to hiney/config.h. The hiney keymap doesn't compile as a result.

noroadsleft · 2019-10-31T21:05:37Z

Thanks!

* add initial hbcp files * adjust hbcp keymaps * update per PR requested changes * add info.json * update LED stuff in regards to my personal keymap * update to new LED pin manipulation code * update info.json * Update keyboards/hineybush/hbcp/hbcp.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/hbcp.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/hbcp.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/hbcp.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/hbcp.c Co-Authored-By: Joel Challis <git@zvecr.com> * Update keyboards/hineybush/hbcp/hbcp.c Co-Authored-By: Joel Challis <git@zvecr.com> * update per pull request suggestions * Update keyboards/hineybush/hbcp/hbcp.c Co-Authored-By: Joel Challis <git@zvecr.com> * update per PR request, update default keymap * Update keyboards/hineybush/hbcp/keymaps/hiney/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/keymaps/hiney/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/keymaps/hiney/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/hineybush/hbcp/info.json Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/hineybush/hbcp/info.json Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/hineybush/hbcp/keymaps/hiney/readme.md Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * update per PR requests * Update keyboards/hineybush/hbcp/info.json Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * add RGB defs to hiney/config.h

hineybush and others added 2 commits September 11, 2019 20:31

add initial hbcp files

10f7307

adjust hbcp keymaps

8f93abd