Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update hbcp keymaps #7275

Merged
merged 5 commits into from
Nov 6, 2019
Merged

update hbcp keymaps #7275

merged 5 commits into from
Nov 6, 2019

Conversation

hineybush
Copy link
Contributor

@hineybush hineybush commented Nov 5, 2019 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • LAYOUT_all not compiling correctly

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft
noroadsleft approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@noroadsleft noroadsleft requested a review from a team November 5, 2019 23:19
@drashna drashna merged commit 002adad into qmk:master Nov 6, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@hineybush
[Keyboard] update hbcp keymaps (qmk#7275)
1046ee5 
* update hbcp keymaps

* update hbcp info.json file

* update readme

* update hbcp "hiney" keymap
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@hineybush @patrl
[Keyboard] update hbcp keymaps (qmk#7275)
1c6f032 
* update hbcp keymaps

* update hbcp info.json file

* update readme

* update hbcp "hiney" keymap
@hineybush hineybush deleted the hbcp branch January 3, 2020 19:27
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@hineybush @HokieGeek
[Keyboard] update hbcp keymaps (qmk#7275)
491d140 
* update hbcp keymaps

* update hbcp info.json file

* update readme

* update hbcp "hiney" keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hineybush @drashna @fauxpark @noroadsleft