Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Enable RGB Light on ARM OLKB Keyboards #7293

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 7, 2019

Description

This enables the bitbang WS2812 support for the ARM OLKB keyboards (Planck Rev6, and Preonic Rev3).

Defaulted to "enabled", since size really isn't a consideration, and you won't see if the LEDs are not soldered on.

Types of Changes

  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team November 7, 2019 21:44
@drashna drashna merged commit cec391d into master Nov 7, 2019
@drashna drashna deleted the keyboard/enable_rgblight_olkb branch November 7, 2019 23:49
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
* Enable RGBLight on Planck Rev6

* Enable RGBLight on Preonic Rev3

All hail zvecr!
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
* Enable RGBLight on Planck Rev6

* Enable RGBLight on Preonic Rev3

All hail zvecr!
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* Enable RGBLight on Planck Rev6

* Enable RGBLight on Preonic Rev3

All hail zvecr!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants