Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Fix calls in handwired/jotanck #7515

Merged
merged 1 commit into from
Nov 30, 2019
Merged

[Keyboard] Fix calls in handwired/jotanck #7515

merged 1 commit into from
Nov 30, 2019

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 30, 2019

The C file for this keyboard was calling keyboard_pre_init_user. Which is wrong.

This fixes that behavior.

Discovered when running make all:drashna

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
[Keyboard] Fix calls in handwired/jotanck
419f089 
The C file for this keyboard was calling `keyboard_pre_init_user`.  Which is wrong.

This fixes that behavior.
@drashna drashna requested a review from a team November 30, 2019 08:56
@noroadsleft noroadsleft requested a review from a team November 30, 2019 11:37
@zvecr zvecr merged commit d98ed28 into master Nov 30, 2019
@noroadsleft noroadsleft deleted the keyboard/jotanck_fix branch November 30, 2019 19:14
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@drashna
[Keyboard] Fix calls in handwired/jotanck (qmk#7515)
b5462c6 
The C file for this keyboard was calling `keyboard_pre_init_user`.  Which is wrong.

This fixes that behavior.
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@drashna @patrl
[Keyboard] Fix calls in handwired/jotanck (qmk#7515)
8959dd3 
The C file for this keyboard was calling `keyboard_pre_init_user`.  Which is wrong.

This fixes that behavior.
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@drashna @HokieGeek
[Keyboard] Fix calls in handwired/jotanck (qmk#7515)
76647f0 
The C file for this keyboard was calling `keyboard_pre_init_user`.  Which is wrong.

This fixes that behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @zvecr @noroadsleft