Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keyboard: Palette1202 #7736

Merged
merged 16 commits into from
Mar 10, 2020
Merged

New Keyboard: Palette1202 #7736

merged 16 commits into from
Mar 10, 2020

Conversation

niltea
Copy link
Contributor

@niltea niltea commented Dec 29, 2019 •
edited
Loading

Description

New PCB - Palette1202

  • Left-hand devede for the illustrators who using Photoshop or Clip Studio Paint.
  • Includes Default keymap, and a keymap for operation check after assembly.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Dec 29, 2019
View reviewed changes
keyboards/palette1202/config.h Outdated Show resolved Hide resolved
keyboards/palette1202/config.h
Comment on lines +53 to +55
/* Feature disable options */
#define NO_DEBUG
#define NO_PRINT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have console enabled, you may want to leave these on, actually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok, thanks! (or should it be enabled?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, these defines should be removed.

If console isn't enabled, they're defined anyways (and may cause compilation issues).

keyboards/palette1202/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/palette1202/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/palette1202/readme.md Outdated Show resolved Hide resolved
keyboards/palette1202/readme.md Outdated Show resolved Hide resolved
keyboards/palette1202/readme.md Outdated Show resolved Hide resolved
keyboards/palette1202/readme.md Outdated Show resolved Hide resolved
keyboards/palette1202/readme.md Outdated Show resolved Hide resolved
keyboards/palette1202/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team December 29, 2019 18:35
noroadsleft
noroadsleft requested changes Dec 29, 2019
View reviewed changes
keyboards/palette1202/info.json Outdated Show resolved Hide resolved
keyboards/palette1202/readme.md Outdated Show resolved Hide resolved
keyboards/palette1202/rules.mk Show resolved Hide resolved
keyboards/palette1202/rules.mk Show resolved Hide resolved
keyboards/palette1202/rules.mk Show resolved Hide resolved
niltea and others added 4 commits December 30, 2019 09:19
@niltea @drashna
Update keyboards/palette1202/config.h
da11d5d 
Co-Authored-By: Drashna Jaelre <drashna@live.com>
@niltea @drashna @noroadsleft
Apply suggestions from code review
c3fc1fd 
Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@niltea
Update readme.md
d4d40d8 
removed unnecessary horizontal line from readme.md
@niltea
Update readme.md
0091e64 
Fixed style, make command example
fauxpark
fauxpark requested changes Jan 14, 2020
View reviewed changes
keyboards/palette1202/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/palette1202/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/palette1202/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/palette1202/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/palette1202/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/palette1202/lib/oled_helper.h Outdated Show resolved Hide resolved
keyboards/palette1202/lib/oled_helper.h Show resolved Hide resolved
keyboards/palette1202/readme.md Outdated Show resolved Hide resolved
keyboards/palette1202/readme.md Outdated Show resolved Hide resolved
keyboards/palette1202/readme.md Outdated Show resolved Hide resolved
drashna
drashna requested changes Jan 15, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you don't need separate mac and windows layers. From what I can tell, the only different is Control vs GUI. And if that is the case, CG_SWAP may be a better solution, since it's the bootmagic keycode to swap Control and GUI (and is persisted). And works even if bootmagic is disabled.

Though, it may not work 100% (I can see a couple of layers that may be problematic.

keyboards/palette1202/palette1202.c Outdated Show resolved Hide resolved
keyboards/palette1202/palette1202.h Outdated Show resolved Hide resolved
keyboards/palette1202/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/palette1202/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/palette1202/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/palette1202/keymaps/default/keymap.c Outdated Show resolved Hide resolved
noroadsleft
noroadsleft approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me otherwise.

keyboards/palette1202/lib/oled_helper.h Outdated Show resolved Hide resolved
@niltea @noroadsleft
Update keyboards/palette1202/lib/oled_helper.h
e5b81cd 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@drashna drashna merged commit 20a0fa9 into qmk:master Mar 10, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 11, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
4f559f7 
* 'master' of https://github.com/qmk/qmk_firmware: (107 commits)
  Add VIA support to Tokyo60. (qmk#8362)
  fix kira80 matrix mapping and add more preset layouts (qmk#8361)
  Rename qmk json-keymap to qmk json2c (qmk#8372)
  format code according to conventions [skip ci]
  Feature: RGBLight layers (qmk#7768)
  Refactor Equinox PCB revisions (qmk#8266)
  Replace tab indentation with spaces in is0 default keymap. (qmk#8368)
  Fix layer debug calls (qmk#8370)
  [Keymap] Added HHKB Keymap and user config (qmk#8119)
  Refactor rgblight_reconfig.h (qmk#7773)
  [Keyboard] Palette1202 (qmk#7736)
  [Keyboard] Helix add split common option (qmk#7718)
  Enable bootmagic lite for CU80 (qmk#8363)
  [Keymap] Update personal keymap (qmk#8354)
  Remove NO_UART defines from config.h for V-USB boards (qmk#8351)
  [Keyboard] Add Kira 80 support (qmk#8342)
  [Keyboard] Add PRKL30 keyboard (qmk#8319)
  Update Dvorak, Colemak and Workman keycode aliases (qmk#8217)
  Move splittest I2C (qmk#8346)
  [Keymap] planck layout for kifinnsson (qmk#8324)
  ...
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@niltea @drashna
@noroadsleft @fauxpark @c0psrul3
[Keyboard] Palette1202 (qmk#7736)
2eafb92 
* added Palette1202

* removed currently unused cords

* Update keyboards/palette1202/config.h

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Apply suggestions from code review

Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update readme.md

removed unnecessary horizontal line from readme.md

* Update readme.md

Fixed style, make command example

* Removed spaces

* removed unused config.h

* fixed defines

* fixed send string on rotate encoder

* fixed layer numbers for OLED Display

* fixed to use existing function to set default layer

qmk#7736 (comment)

* flipped rotary encoder directions

* Added layer for Clip studio on iOS

* Update keyboards/palette1202/rules.mk

Co-Authored-By: Ryan <fauxpark@gmail.com>

* Update keyboards/palette1202/lib/oled_helper.h

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@niltea @drashna
@noroadsleft @fauxpark @sowbug
[Keyboard] Palette1202 (qmk#7736)
7c3933e 
* added Palette1202

* removed currently unused cords

* Update keyboards/palette1202/config.h

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Apply suggestions from code review

Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update readme.md

removed unnecessary horizontal line from readme.md

* Update readme.md

Fixed style, make command example

* Removed spaces

* removed unused config.h

* fixed defines

* fixed send string on rotate encoder

* fixed layer numbers for OLED Display

* fixed to use existing function to set default layer

qmk#7736 (comment)

* flipped rotary encoder directions

* Added layer for Clip studio on iOS

* Update keyboards/palette1202/rules.mk

Co-Authored-By: Ryan <fauxpark@gmail.com>

* Update keyboards/palette1202/lib/oled_helper.h

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
@niltea @drashna
@noroadsleft @fauxpark @HokieGeek
[Keyboard] Palette1202 (qmk#7736)
6c2b2a0 
* added Palette1202

* removed currently unused cords

* Update keyboards/palette1202/config.h

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Apply suggestions from code review

Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update readme.md

removed unnecessary horizontal line from readme.md

* Update readme.md

Fixed style, make command example

* Removed spaces

* removed unused config.h

* fixed defines

* fixed send string on rotate encoder

* fixed layer numbers for OLED Display

* fixed to use existing function to set default layer

qmk#7736 (comment)

* flipped rotary encoder directions

* Added layer for Clip studio on iOS

* Update keyboards/palette1202/rules.mk

Co-Authored-By: Ryan <fauxpark@gmail.com>

* Update keyboards/palette1202/lib/oled_helper.h

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@niltea @drashna
@noroadsleft @fauxpark @kujawakk
[Keyboard] Palette1202 (qmk#7736)
043eac8 
* added Palette1202

* removed currently unused cords

* Update keyboards/palette1202/config.h

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Apply suggestions from code review

Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update readme.md

removed unnecessary horizontal line from readme.md

* Update readme.md

Fixed style, make command example

* Removed spaces

* removed unused config.h

* fixed defines

* fixed send string on rotate encoder

* fixed layer numbers for OLED Display

* fixed to use existing function to set default layer

qmk#7736 (comment)

* flipped rotary encoder directions

* Added layer for Clip studio on iOS

* Update keyboards/palette1202/rules.mk

Co-Authored-By: Ryan <fauxpark@gmail.com>

* Update keyboards/palette1202/lib/oled_helper.h

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@niltea @drashna
@noroadsleft @fauxpark @jakobaa
[Keyboard] Palette1202 (qmk#7736)
7be7350 
* added Palette1202

* removed currently unused cords

* Update keyboards/palette1202/config.h

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Apply suggestions from code review

Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update readme.md

removed unnecessary horizontal line from readme.md

* Update readme.md

Fixed style, make command example

* Removed spaces

* removed unused config.h

* fixed defines

* fixed send string on rotate encoder

* fixed layer numbers for OLED Display

* fixed to use existing function to set default layer

qmk#7736 (comment)

* flipped rotary encoder directions

* Added layer for Clip studio on iOS

* Update keyboards/palette1202/rules.mk

Co-Authored-By: Ryan <fauxpark@gmail.com>

* Update keyboards/palette1202/lib/oled_helper.h

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@niltea @drashna
@noroadsleft @fauxpark @jakeisnt
[Keyboard] Palette1202 (qmk#7736)
bf86402 
* added Palette1202

* removed currently unused cords

* Update keyboards/palette1202/config.h

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Apply suggestions from code review

Co-Authored-By: Drashna Jaelre <drashna@live.com>
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* Update readme.md

removed unnecessary horizontal line from readme.md

* Update readme.md

Fixed style, make command example

* Removed spaces

* removed unused config.h

* fixed defines

* fixed send string on rotate encoder

* fixed layer numbers for OLED Display

* fixed to use existing function to set default layer

qmk#7736 (comment)

* flipped rotary encoder directions

* Added layer for Clip studio on iOS

* Update keyboards/palette1202/rules.mk

Co-Authored-By: Ryan <fauxpark@gmail.com>

* Update keyboards/palette1202/lib/oled_helper.h

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@niltea @drashna @fauxpark @noroadsleft @mechmerlin