Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker script and document #7786

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Fix docker script and document #7786

merged 1 commit into from
Jan 10, 2020

Conversation

shelaf
Copy link
Contributor

@shelaf shelaf commented Jan 4, 2020

Description

Fixed error when keyboard parameter is omitted in interactive mode.

util/docker_build.sh
keyboard=
make: *** empty string invalid as file name.  Stop.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@shelaf
Fix docker script and document
8308a5f 
Fixed error when keyboard parameter is omitted in interactive mode.
@zvecr zvecr requested a review from a team January 4, 2020 16:49
@drashna drashna requested a review from a team January 4, 2020 20:53
@zvecr zvecr merged commit 5a02cc0 into qmk:master Jan 10, 2020
@zvecr
Copy link
Member

zvecr commented Jan 10, 2020

Thanks!

@shelaf shelaf deleted the fix_docker branch January 10, 2020 01:11
@shelaf shelaf mentioned this pull request Jan 4, 2020
Merged
13 tasks
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@shelaf @HokieGeek
Fix docker script and document (qmk#7786)
557e6a1 
Fixed error when keyboard parameter is omitted in interactive mode.
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@shelaf @kujawakk
Fix docker script and document (qmk#7786)
3276c71 
Fixed error when keyboard parameter is omitted in interactive mode.
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@shelaf @zvecr
Fix docker script and document (qmk#7786)
279114b 
Fixed error when keyboard parameter is omitted in interactive mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shelaf @zvecr @drashna