Cleanup check for PERMISSIVE_HOLD #7861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caused by #5009 (aka, me)
|
How many people outside the repo have defined PER_KEY_TAPPING_TERM? |
ridingqwerty
approved these changes
Jan 11, 2020
|
Exactly. It's ... an artifact of me try getting the feature to work, where I changed the name. It's not used anywhere else. |
noroadsleft
approved these changes
Jan 11, 2020
Its not used anywhere else in That aside, I do agree that the impact is very low, but i cant see it as zero. |
zvecr
approved these changes
Jan 12, 2020
drashna
added a commit
to zsa/qmk_firmware
that referenced
this pull request
Feb 12, 2020
* Fix bug in PERMISSIVE_HOLD check caused by qmk#5009 (aka, me) * Remove check for per key
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Feb 14, 2020
* Fix bug in PERMISSIVE_HOLD check caused by qmk#5009 (aka, me) * Remove check for per key
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
* Fix bug in PERMISSIVE_HOLD check caused by qmk#5009 (aka, me) * Remove check for per key
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Feb 26, 2020
* Fix bug in PERMISSIVE_HOLD check caused by qmk#5009 (aka, me) * Remove check for per key
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* Fix bug in PERMISSIVE_HOLD check caused by qmk#5009 (aka, me) * Remove check for per key
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Fix bug in PERMISSIVE_HOLD check caused by qmk#5009 (aka, me) * Remove check for per key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extra, unneeded check
Types of Changes
Issues Fixed or Closed by This PR