Enforce definition of DIODE_DIRECTION for non-custom matrix boards
#7915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
requested changes
Jan 16, 2020
noroadsleft
approved these changes
Jan 16, 2020
drashna
approved these changes
Jan 18, 2020
|
@fauxpark can we set the onekey ones in <keyboards/handwired/onekey/config.h> instead of in each board. |
zvecr
approved these changes
Jan 19, 2020
This was referenced Jan 19, 2020
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Feb 12, 2020
…mk#7915) * Enforce definition of `DIODE_DIRECTION` for non-custom matrix boards * Define diode direction for failing boards * Matching parentheses * Put onekey diode directions in top level config
13 tasks
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Feb 14, 2020
…mk#7915) * Enforce definition of `DIODE_DIRECTION` for non-custom matrix boards * Define diode direction for failing boards * Matching parentheses * Put onekey diode directions in top level config
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
…mk#7915) * Enforce definition of `DIODE_DIRECTION` for non-custom matrix boards * Define diode direction for failing boards * Matching parentheses * Put onekey diode directions in top level config
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Feb 26, 2020
…mk#7915) * Enforce definition of `DIODE_DIRECTION` for non-custom matrix boards * Define diode direction for failing boards * Matching parentheses * Put onekey diode directions in top level config
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
…mk#7915) * Enforce definition of `DIODE_DIRECTION` for non-custom matrix boards * Define diode direction for failing boards * Matching parentheses * Put onekey diode directions in top level config
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…mk#7915) * Enforce definition of `DIODE_DIRECTION` for non-custom matrix boards * Define diode direction for failing boards * Matching parentheses * Put onekey diode directions in top level config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
DIODE_DIRECTIONis not defined, the default is COL2ROW (0). This is because the preprocessor directives in matrix.c check thatDIODE_DIRECTION == COL2ROWwithout first verifying that it's even defined at all, and [undefined] == 0, apparently.I anticipate some build failures here, from any boards that are "exploiting" this to avoid defining
DIODE_DIRECTION. (eg.keebio/bfo9000). I'll try to fix them up in this PR.Types of Changes
Issues Fixed or Closed by This PR
Checklist