Keymap for XD75 with 7U spacebar EN-RU gamers

[buzzlighter1]

Description

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[drashna]

Just a couple of layer related cade changes, but otherwise LGTM.

[noroadsleft]

To elaborate on my comment regarding the layers.json file:

That file contains the contents of the key assignments that are sent to the QMK Compiler API when a compile job is launched in QMK Configurator. When that happens, the keyboard, keymap name, and layout macro used are provided separately from this data. The file contains no information on its own that can be imported back into QMK Configurator. The only way to get further use from this file is to edit it by hand in a text editor, providing the keyboard, keymap name, and layout macro that were used on the original compile job.

If you were to export the keymap JSON from Configurator at the time of compiling, and compare it to the layers.json file, you will see that layers.json is a subset of the data in the export, while the export is the complete data set, and can be imported back into Configurator.

---

Also, for future reference, we recommend against committing to your master branch as you've done here, because pull requests from modified master branches can make it more difficult to keep your QMK fork updated. It is highly recommended for QMK development – regardless of what is being done or where – to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your fork updated here:

Best Practices: Your Fork's Master: Update Often, Commit Never

If you need any help with this just ask.

You do not need to close this pull request at this time. Until your pull request is merged, please continue to commit relevant changes to your master branch.

[buzzlighter1]

I suspected something like that about the layers.json file, thank you the explanation!

My goal was to make the keymap available to the public. I have followed the guide in the link mentioned above, but I thought I need to merge it into qmk:master to open it for the public. If the keymap in the buzzlighter1:master serves the goal then I probably should cancel this merge?...

[noroadsleft]

Merging your keymap to qmk:master does make it more visible in my opinion, and later users may find something in your keymap they like.

If you want to include the JSON export from Configurator, that's fine and allowed, but it should be the keymap.json file with the complete data set, rather than the layers.json file.

Also, QMK's make system has the ability to compile keymap.json files into keymap.c files, so for ease of use, I'd suggest naming the keymap.json file to something more like buzzlighter1_keymap.json, because our CI system will compile the JSON instead of the C file if it finds both keymap.c and keymap.json in the same folder, and the C file supports more features.

There are some esoteric issues with Configurator keymap.json files, as far as compiling them through QMK Configurator. Those issues are documented here. (I really should make a doc for this.) Also, the first part of that post is also out of scope for your specific use case; you should scroll down to "You can't use default as the value for the keymap key" and read from there.

[noroadsleft]

@buzzlighter1 If you want to contribute a QMK Configurator keymap file, additional pull requests are accepted.

I'm going to merge this; you should resynchronize your master branch now.

Thanks!