Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update most cannonkeys 072 boards to rely on core QMK/VIA support #8206

Conversation

awkannan
Copy link
Contributor

@awkannan awkannan commented Feb 20, 2020

Description

My apologies to @zvecr, I know you had a PR out but I wanted to one-fell-swoop my 072 folder away, now that all the functionality is in core QMK.

I have removed my special 072 folder and now rely on the core QMK support for those features.

I built the project keyboard one, so you don't have to ask for signoff ;)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested review from zvecr and a team February 20, 2020 04:00
@awkannan
Copy link
Contributor Author

Satisfaction75 has too much custom stuff

@drashna drashna requested a review from tzarc February 20, 2020 06:11
@drashna drashna requested a review from a team February 21, 2020 02:01
@tzarc
Copy link
Member

tzarc commented Feb 21, 2020

I think the fact that there's some question as to whether this would break other non-cannonkeys boards requires a bit more investigation.

Kinda leaning towards waiting until future branch gets merged before revisiting this, mainly as any of the chibios conf changes will collide, and any of the other boards that were direct copies of cannonkeys F072 will end up being a problem.

@stale
Copy link

stale bot commented Apr 6, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@awkannan awkannan closed this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants