Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add ReverseStudio-DecadePad #8553

Merged
merged 15 commits into from
Apr 5, 2020
Merged

[Keyboard] Add ReverseStudio-DecadePad #8553

merged 15 commits into from
Apr 5, 2020

Conversation

huajijam
Copy link
Contributor

@huajijam huajijam commented Mar 25, 2020 •
edited by zvecr
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Mar 26, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename the files so that they're all lower case?

Due to issues with houw casing is handling different in different OS's, it's easiest if they're kept consistent, eg, all lower case.

keyboards/ReverseStudio/DecadePad/DecadePad.h Outdated Show resolved Hide resolved
keyboards/ReverseStudio/DecadePad/keymap.c Outdated Show resolved Hide resolved
keyboards/ReverseStudio/DecadePad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
zvecr
zvecr requested changes Mar 26, 2020
View reviewed changes
keyboards/ReverseStudio/DecadePad/keymap.c Outdated Show resolved Hide resolved
keyboards/ReverseStudio/DecadePad/layout.json Outdated Show resolved Hide resolved
@zvecr zvecr added the keyboard label Mar 26, 2020
zvecr
zvecr requested changes Mar 26, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Community layouts would be supported by this, not sure what you had as the commits have now gone. But I can confirm, the suggestions from Drashna work.

As a FYI, you have also reverted the lower case rename.

Also, can you add a keyboard level readme following the template.

@huajijam
Copy link
Contributor Author

Now the firmware have bugs
I don't know why Col2Row5 at board will be Col1Row5,and Col3Row5 will be Col2Row5
I am trying to revert the version back,but it doesn't succes

@huajijam
Copy link
Contributor Author

Community layouts is worked, but the col problem is still, it just happen between row5col2 and col3,looks like my firmware matrix is wrong, i try to build a firmware at https://kbfirmware.com/ and it works,
image

@huajijam
Copy link
Contributor Author

All bugs have been fix,thx guys

@huajijam huajijam requested review from zvecr and drashna March 26, 2020 19:54
zvecr
zvecr requested changes Mar 26, 2020
View reviewed changes
keyboards/reversestudio/decadepad/info.json Outdated Show resolved Hide resolved
keyboards/reversestudio/decadepad/rules.mk Outdated Show resolved Hide resolved
@huajijam huajijam requested a review from zvecr March 27, 2020 12:11
@huajijam
Merge
f892b1a 
merge
@drashna drashna requested a review from a team March 29, 2020 19:52
fauxpark
fauxpark requested changes Mar 30, 2020
View reviewed changes
keyboards/reversestudio/decadepad/decadepad.c Outdated Show resolved Hide resolved
keyboards/reversestudio/decadepad/keymap.c Outdated Show resolved Hide resolved
keyboards/reversestudio/decadepad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/reversestudio/readme.md Outdated Show resolved Hide resolved
keyboards/reversestudio/decadepad/rules.mk Outdated Show resolved Hide resolved
fauxpark
fauxpark approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just these tiny tweaks, LGTM otherwise :)

keyboards/reversestudio/decadepad/readme.md Show resolved Hide resolved
keyboards/reversestudio/decadepad/readme.md Show resolved Hide resolved
@huajijam huajijam requested a review from fauxpark March 31, 2020 13:43
@drashna drashna requested review from noroadsleft and a team March 31, 2020 21:28
noroadsleft
noroadsleft requested changes Apr 3, 2020
View reviewed changes
keyboards/reversestudio/decadepad/info.json Outdated Show resolved Hide resolved
keyboards/reversestudio/decadepad/config.h Outdated Show resolved Hide resolved
keyboards/reversestudio/decadepad/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/reversestudio/decadepad/keymaps/via/rule.mk Outdated Show resolved Hide resolved
keyboards/reversestudio/decadepad/rules.mk Outdated Show resolved Hide resolved
@wilba wilba mentioned this pull request Apr 4, 2020
Merged
7 tasks
@huajijam
Copy link
Contributor Author

huajijam commented Apr 4, 2020

thx guys, via is finally enable now

@drashna drashna changed the title Add ReverseStudio-DecadePad [Keyboard] Add ReverseStudio-DecadePad Apr 5, 2020
@drashna drashna merged commit 04c81a0 into qmk:master Apr 5, 2020
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
@huajijam @HokieGeek
[Keyboard] Add ReverseStudio-DecadePad (qmk#8553)
9cee28e 
* ADD DecadePad

* Fix Key display bug

* fix

* firmware1

THIS IS A Backup commit

* firmware2

* rename all fill with lower case

* fix bug

* Final Version

Fix all bugs

* Requested change apply

* suggested apply

* change apply

* via test

* Apply change and fix via support problem
Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
@huajijam @Quarren42
[Keyboard] Add ReverseStudio-DecadePad (qmk#8553)
2163499 
* ADD DecadePad

* Fix Key display bug

* fix

* firmware1

THIS IS A Backup commit

* firmware2

* rename all fill with lower case

* fix bug

* Final Version

Fix all bugs

* Requested change apply

* suggested apply

* change apply

* via test

* Apply change and fix via support problem
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@huajijam @kujawakk
[Keyboard] Add ReverseStudio-DecadePad (qmk#8553)
7f681f7 
* ADD DecadePad

* Fix Key display bug

* fix

* firmware1

THIS IS A Backup commit

* firmware2

* rename all fill with lower case

* fix bug

* Final Version

Fix all bugs

* Requested change apply

* suggested apply

* change apply

* via test

* Apply change and fix via support problem
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@huajijam @lorenzoernesto
[Keyboard] Add ReverseStudio-DecadePad (qmk#8553)
17a699e 
* ADD DecadePad

* Fix Key display bug

* fix

* firmware1

THIS IS A Backup commit

* firmware2

* rename all fill with lower case

* fix bug

* Final Version

Fix all bugs

* Requested change apply

* suggested apply

* change apply

* via test

* Apply change and fix via support problem
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@huajijam @sowbug
[Keyboard] Add ReverseStudio-DecadePad (qmk#8553)
ac00f98 
* ADD DecadePad

* Fix Key display bug

* fix

* firmware1

THIS IS A Backup commit

* firmware2

* rename all fill with lower case

* fix bug

* Final Version

Fix all bugs

* Requested change apply

* suggested apply

* change apply

* via test

* Apply change and fix via support problem
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jun 11, 2020
Merge remote-tracking branch 'upstream/master'
851f7c2 
* upstream/master: (312 commits)
  updated rules.mk and default keymap of Wonderland for VIA support (qmk#8668)
  Added Caps Lock LED handler to wilba.tech PCBs (qmk#8660)
  Add keyboard TGR-910 (qmk#8683)
  V-USB remote wakeup (qmk#7627)
  Add Greek keymap (qmk#8636)
  Add Polish keymap (qmk#8637)
  Add Korean keymap (qmk#8635)
  [Keyboard] Add 60_hhkb layout to hhkb (qmk#8618)
  [Keyboard] romeo - add via layout (qmk#8667)
  [Keyboard] Add ReverseStudio-DecadePad (qmk#8553)
  [Keyboard] Add bat43 Keyboard (qmk#8648)
  minor tweaks
  Fix saving output from avrdude and dfu-programmer
  Use version_arg in ESSENTIAL_BINARIES dict
  Fixes qmk#8541 by getting version from -dumpversion then --version as fallback
  VIA Support: 1upkeyboards Sweet16 (qmk#8652)
  [Keyboard] Lattice60 (qmk#8603)
  Discipline - Add ISO compatibility, rawHID enable, via layout (qmk#8627)
  [Keyboard] Add Orbit-X Keyboard (qmk#8605)
  add 60_tsangan_hhkb layout to GH60 rev. C (qmk#8617)
  ...
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@huajijam @jakobaa
[Keyboard] Add ReverseStudio-DecadePad (qmk#8553)
6fdf903 
* ADD DecadePad

* Fix Key display bug

* fix

* firmware1

THIS IS A Backup commit

* firmware2

* rename all fill with lower case

* fix bug

* Final Version

Fix all bugs

* Requested change apply

* suggested apply

* change apply

* via test

* Apply change and fix via support problem
thorstenweber83 pushed a commit to thorstenweber83/qmk_firmware that referenced this pull request Sep 2, 2020
@huajijam @thorstenweber83
[Keyboard] Add ReverseStudio-DecadePad (qmk#8553)
d8e5afc 
* ADD DecadePad

* Fix Key display bug

* fix

* firmware1

THIS IS A Backup commit

* firmware2

* rename all fill with lower case

* fix bug

* Final Version

Fix all bugs

* Requested change apply

* suggested apply

* change apply

* via test

* Apply change and fix via support problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huajijam @drashna @fauxpark @zvecr @noroadsleft