Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasdat code controller #8858

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Add wasdat code controller #8858

merged 3 commits into from
Apr 23, 2020

Conversation

evyd13
Copy link
Contributor

@evyd13 evyd13 commented Apr 19, 2020

Description

Add the wasdat code controller, it's very similar to the wasdat.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the next breaking changes cycle we should refactor these two to wasdat/v2 and wasdat/code.

keyboards/maartenwut/wasdat_code/config.h Outdated Show resolved Hide resolved
keyboards/maartenwut/wasdat_code/matrix.c Outdated Show resolved Hide resolved
keyboards/maartenwut/wasdat_code/matrix.c Outdated Show resolved Hide resolved
keyboards/maartenwut/wasdat_code/matrix.c Outdated Show resolved Hide resolved
keyboards/maartenwut/wasdat_code/matrix.c Outdated Show resolved Hide resolved
keyboards/maartenwut/wasdat_code/matrix.c Outdated Show resolved Hide resolved
keyboards/maartenwut/wasdat_code/matrix.c Outdated Show resolved Hide resolved
keyboards/maartenwut/wasdat_code/matrix.c Outdated Show resolved Hide resolved
keyboards/maartenwut/wasdat_code/matrix.c Outdated Show resolved Hide resolved
keyboards/maartenwut/wasdat_code/matrix.c Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team April 19, 2020 20:26
@evyd13
Copy link
Contributor Author

evyd13 commented Apr 19, 2020

During the next breaking changes cycle we should refactor these two to wasdat/v2 and wasdat_code.

Not sure what you mean here, could you elaborate?

@fauxpark
Copy link
Member

Oops, fixed. Basically just a note to myself (or anyone else) that these two boards should probably go under a common wasdat/ subfolder, as there is some shared config/code. But it'll be fine to merge this as it's currently named.

@evyd13
Copy link
Contributor Author

evyd13 commented Apr 22, 2020

Please merge?

@fauxpark fauxpark requested a review from a team April 22, 2020 22:55
keyboards/maartenwut/wasdat_code/info.json Outdated Show resolved Hide resolved
keyboards/maartenwut/wasdat_code/info.json Outdated Show resolved Hide resolved
@noroadsleft noroadsleft merged commit ccc8338 into qmk:master Apr 23, 2020
@noroadsleft
Copy link
Member

Thanks!

@evyd13 evyd13 deleted the wasdat-code branch April 23, 2020 00:36
rockwarrior added a commit to rockwarrior/qmk_firmware that referenced this pull request Apr 23, 2020
* upstream: (1037 commits)
  [Keyboard] Add wasdat code controller (qmk#8858)
  fix sample code indent in feature_encoders.md (qmk#8883)
  [Keymap] Clean up my ergo keymaps and userspace (qmk#8857)
  idb 60 Bugfixes / Preparations for Open Source Hardware (qmk#8866)
  Rebound: add rev2 and thus rev1 as well (qmk#8630)
  Update vitamins included default keymap, enable NKRO, rev2 rgbsplit (qmk#8871)
  Update to xealousbrown. (qmk#8215)
  [Keyboard] DMQ Design SPIN (qmk#8820)
  Wheatfield Blocked65: Update RGBLED num (qmk#8725)
  Add VIA support to ID80 (qmk#8791)
  CFTKB Mysterium & Discipad VIA support (qmk#8794)
  Clean up ATSAM ifdefs (qmk#8808)
  [Docs] Japanese translation of docs/feature_encoders.md (qmk#8843)
  Add naked60 layout, clean up my userspace files and rules.mk. (qmk#8848)
  Fixing DecadePad Numlock LED Bug (qmk#8831)
  [Docs] Japanese translation of docs/feature_command.md (qmk#8672)
  Add support for YMD75 rev 2 (qmk#8853)
  Remove no-longer-necessary LTO checks from keyboards' config.h files (qmk#8773)
  Fix ta-65 tsangan layouts (qmk#8855)
  Fix Plain60 layout (qmk#8854)
  ...
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request May 3, 2020
* Initial keyboard upload

* Code cleanup and product name

* Fix sequence in info.json layouts
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
* Initial keyboard upload

* Code cleanup and product name

* Fix sequence in info.json layouts
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
* Initial keyboard upload

* Code cleanup and product name

* Fix sequence in info.json layouts
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* Initial keyboard upload

* Code cleanup and product name

* Fix sequence in info.json layouts
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* Initial keyboard upload

* Code cleanup and product name

* Fix sequence in info.json layouts
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
* Initial keyboard upload

* Code cleanup and product name

* Fix sequence in info.json layouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants