Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Keyboard: Project Keyboard Signature 87 #9062

Merged
merged 16 commits into from
Jun 10, 2020
Merged

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented May 10, 2020

Description

Signature 87 from Project Keyboard. This is my first ARM pull request! Hopefully I did it right.

Tracing, and preliminary code was done by 159, and was handed to me for completion. I've added

  • VIA support
  • Proper electrical matrix labeling
  • Additional LAYOUTs for community layout support
  • QMK Configurator Support
  • Cleanups here and there

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/projectkb/signature87/bootloader_defs.h Outdated Show resolved Hide resolved
keyboards/projectkb/signature87/rules.mk Outdated Show resolved Hide resolved
keyboards/projectkb/signature87/rules.mk Show resolved Hide resolved
keyboards/projectkb/signature87/rules.mk Outdated Show resolved Hide resolved
mechmerlin and others added 4 commits May 11, 2020 09:09
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
keyboards/projectkb/signature87/config.h Outdated Show resolved Hide resolved
mechmerlin and others added 2 commits May 15, 2020 16:12
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@mechmerlin mechmerlin added the via Adds via keymap and/or updates keyboard for via support label May 21, 2020
@zvecr zvecr merged commit a056d94 into qmk:master Jun 10, 2020
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jun 11, 2020
* upstream/master: (82 commits)
  Fix my personal keymap // Custom keymap for Kbdfans/kbd67/rev2 with improvements on Accessibility (qmk#9207)
  Murcielago: improve default keymap (qmk#9363)
  Really fix Ubuntu/Debian setup when $PATH contains spaces (qmk#9370)
  Fix Configurator layout data for clueboard/2x1800/2019 (qmk#9373)
  Fixing Iron165 VIA Keymap (qmk#9298)
  Fix Ubuntu/Debian setup when $PATH contains spaces (qmk#9307)
  Add documentation for selecting an Arm MCU (qmk#9046)
  [Docs] Fixed the hyperlink to `/users/_example/`. (qmk#9326)
  [keyboard] Project Keyboard Signature 87 (qmk#9062)
  Include `pointing_device_send` in docs (qmk#9185)
  Fix one shot swaphands compiler error when NO_ACTION_ONESHOT is defined (qmk#9296)
  [Keymap] WPM-responsive OLED animation in personal keymap (qmk#9264)
  Add bat43 rev2 (qmk#9319)
  [Keymap] Add dual layer keymap for xd002 macropad (qmk#9222)
  [Keyboard] Wazowski 23-19 PCB Support (qmk#9198)
  adds support for the atmega328 (qmk#9043)
  fix rgb mode selection and lighting increments for the 1894 (qmk#9336)
  Add Sinc keyboard (qmk#8986)
  Add new iris keymap 'fluffactually' (qmk#9325)
  kbdfans/kbd67/rev2: Fix ISO layout macro (qmk#9329)
  ...
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jun 12, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (461 commits)
  Fix my personal keymap // Custom keymap for Kbdfans/kbd67/rev2 with improvements on Accessibility (qmk#9207)
  Murcielago: improve default keymap (qmk#9363)
  Really fix Ubuntu/Debian setup when $PATH contains spaces (qmk#9370)
  Fix Configurator layout data for clueboard/2x1800/2019 (qmk#9373)
  Fixing Iron165 VIA Keymap (qmk#9298)
  Fix Ubuntu/Debian setup when $PATH contains spaces (qmk#9307)
  Add documentation for selecting an Arm MCU (qmk#9046)
  [Docs] Fixed the hyperlink to `/users/_example/`. (qmk#9326)
  [keyboard] Project Keyboard Signature 87 (qmk#9062)
  Include `pointing_device_send` in docs (qmk#9185)
  Fix one shot swaphands compiler error when NO_ACTION_ONESHOT is defined (qmk#9296)
  [Keymap] WPM-responsive OLED animation in personal keymap (qmk#9264)
  Add bat43 rev2 (qmk#9319)
  [Keymap] Add dual layer keymap for xd002 macropad (qmk#9222)
  [Keyboard] Wazowski 23-19 PCB Support (qmk#9198)
  adds support for the atmega328 (qmk#9043)
  fix rgb mode selection and lighting increments for the 1894 (qmk#9336)
  Add Sinc keyboard (qmk#8986)
  Add new iris keymap 'fluffactually' (qmk#9325)
  kbdfans/kbd67/rev2: Fix ISO layout macro (qmk#9329)
  ...
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* preliminary check in, basically a copy from 159's github with a few additions to get it to compile

* update readme

* fixup the LAYOUT macro labels to be more reasonable

* add tkl_ansi LAYOUT macro for community layout support

* clean up rules.mk, add community layout suport, and add in bootloader

* add a tsangan layout macro

* spruce up readme

* add VIA keymap

* add qmk configurator support

* Update keyboards/projectkb/signature87/rules.mk

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/projectkb/signature87/rules.mk

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/projectkb/signature87/rules.mk

Co-authored-by: Joel Challis <git@zvecr.com>

* remove unneeded file

* Update keyboards/projectkb/signature87/config.h

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/projectkb/signature87/rules.mk

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update keyboards/projectkb/signature87/config.h

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* preliminary check in, basically a copy from 159's github with a few additions to get it to compile

* update readme

* fixup the LAYOUT macro labels to be more reasonable

* add tkl_ansi LAYOUT macro for community layout support

* clean up rules.mk, add community layout suport, and add in bootloader

* add a tsangan layout macro

* spruce up readme

* add VIA keymap

* add qmk configurator support

* Update keyboards/projectkb/signature87/rules.mk

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/projectkb/signature87/rules.mk

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/projectkb/signature87/rules.mk

Co-authored-by: Joel Challis <git@zvecr.com>

* remove unneeded file

* Update keyboards/projectkb/signature87/config.h

Co-authored-by: Joel Challis <git@zvecr.com>

* Update keyboards/projectkb/signature87/rules.mk

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update keyboards/projectkb/signature87/config.h

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@mechmerlin mechmerlin deleted the feature/sig87 branch January 26, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants