Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added defines for RAISE and LOWER #9083

Merged
merged 1 commit into from
May 13, 2020
Merged

Added defines for RAISE and LOWER #9083

merged 1 commit into from
May 13, 2020

Conversation

Xyverz
Copy link
Contributor

@Xyverz Xyverz commented May 13, 2020

I like being able to use layers. This fixes my screw-up from my last
code overhaul.

Added defines for RAISE and LOWER, and removed RAISE LOWER from the keycode enum. (Thanks @ridingqwerty!)

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Xyverz
Added defines for RAISE and LOWER
0565dc6 
I like being able to use layers. This fixes my screw-up from my last
code overhaul.
@tzarc tzarc requested a review from a team May 13, 2020 00:45
@tzarc tzarc merged commit 774384c into qmk:master May 13, 2020
@Xyverz
Copy link
Contributor Author

Xyverz commented May 13, 2020

Thanks guys! Much appreciated!

bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@Xyverz @lorenzoernesto
Added defines for RAISE and LOWER (qmk#9083)
5266b70 
I like being able to use layers. This fixes my screw-up from my last
code overhaul.
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@Xyverz @sowbug
Added defines for RAISE and LOWER (qmk#9083)
b270e41 
I like being able to use layers. This fixes my screw-up from my last
code overhaul.
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@Xyverz @turky
Added defines for RAISE and LOWER (qmk#9083)
5615a80 
I like being able to use layers. This fixes my screw-up from my last
code overhaul.
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@Xyverz @jakobaa
Added defines for RAISE and LOWER (qmk#9083)
98c718d 
I like being able to use layers. This fixes my screw-up from my last
code overhaul.
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@Xyverz @sjmacneil
Added defines for RAISE and LOWER (qmk#9083)
aad3d74 
I like being able to use layers. This fixes my screw-up from my last
code overhaul.
@Xyverz Xyverz deleted the planck_fix branch October 20, 2022 18:08
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Xyverz
Added defines for RAISE and LOWER (qmk#9083)
537fb74 
I like being able to use layers. This fixes my screw-up from my last
code overhaul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@ridingqwerty ridingqwerty ridingqwerty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xyverz @tzarc @ridingqwerty