Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add h60 PCB #9242

Merged
merged 9 commits into from
Jun 22, 2020
Merged

add h60 PCB #9242

merged 9 commits into from
Jun 22, 2020

Conversation

hineybush
Copy link
Contributor

@hineybush hineybush commented May 30, 2020 •
edited
Loading

Description

Add h60 PCB

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Jun 1, 2020
View reviewed changes
keyboards/hineybush/h60/info.json Outdated Show resolved Hide resolved
keyboards/hineybush/h60/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/hineybush/h60/keymaps/kei/config.h Outdated Show resolved Hide resolved
keyboards/hineybush/h60/keymaps/via/config.h Outdated Show resolved Hide resolved
keyboards/hineybush/h60/rules.mk Show resolved Hide resolved
keyboards/hineybush/h60/rules.mk Outdated Show resolved Hide resolved
keyboards/hineybush/h60/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark added keyboard via Adds via keymap and/or updates keyboard for via support labels Jun 1, 2020
@fauxpark fauxpark requested a review from a team June 1, 2020 20:35
@hineybush hineybush mentioned this pull request Jun 2, 2020
Merged
6 tasks
@drashna drashna requested a review from a team June 5, 2020 09:17
@zvecr zvecr requested a review from fauxpark June 10, 2020 22:35
fauxpark
fauxpark requested changes Jun 11, 2020
View reviewed changes
keyboards/hineybush/h60/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h60/keymaps/kei/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h60/keymaps/via/keymap.c Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Jun 13, 2020
View reviewed changes
keyboards/hineybush/h60/h60.h Outdated Show resolved Hide resolved
keyboards/hineybush/h60/h60.h Outdated Show resolved Hide resolved
keyboards/hineybush/h60/rules.mk Outdated Show resolved Hide resolved
hineybush and others added 6 commits June 16, 2020 17:07
@hineybush @fauxpark
Update keyboards/hineybush/h60/keymaps/default/keymap.c
d123b8a 
Co-authored-by: Ryan <fauxpark@gmail.com>
@hineybush @fauxpark
Update keyboards/hineybush/h60/keymaps/kei/keymap.c
a19134b 
Co-authored-by: Ryan <fauxpark@gmail.com>
@hineybush @fauxpark
Update keyboards/hineybush/h60/keymaps/via/keymap.c
77e82a8 
Co-authored-by: Ryan <fauxpark@gmail.com>
@hineybush @noroadsleft
Update keyboards/hineybush/h60/h60.h
ccc5c32 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@hineybush @noroadsleft
Update keyboards/hineybush/h60/h60.h
7b43a0e 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@hineybush @noroadsleft
Update keyboards/hineybush/h60/rules.mk
8db79f9 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@drashna drashna requested a review from noroadsleft June 18, 2020 03:43
noroadsleft
noroadsleft approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 24b0cda into qmk:master Jun 22, 2020
@noroadsleft
Copy link
Member

Thanks!

jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@hineybush @jakobaa
[Keyboard] add h60 PCB (qmk#9242)
1a8262a 
* add h60 initial files

* add h60 image

* updated per PR request

* Update keyboards/hineybush/h60/keymaps/default/keymap.c

* Update keyboards/hineybush/h60/keymaps/kei/keymap.c

* Update keyboards/hineybush/h60/keymaps/via/keymap.c

* Update keyboards/hineybush/h60/h60.h

* Update keyboards/hineybush/h60/h60.h

* Update keyboards/hineybush/h60/rules.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hineybush @noroadsleft @drashna @fauxpark @zvecr