Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigger combo index #9318

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Bigger combo index #9318

merged 2 commits into from
Jul 16, 2020

Conversation

sevanteri
Copy link
Contributor

@sevanteri sevanteri commented Jun 6, 2020

Description

Changes uint8_t to uin16_t when looping over combos. With 16 bits we can have much more than 256 combos.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@sevanteri sevanteri changed the base branch from master to develop June 6, 2020 10:42
@sevanteri sevanteri marked this pull request as ready for review June 6, 2020 10:42
@zvecr zvecr added breaking_change Changes that need to wait for a version increment core enhancement labels Jun 20, 2020
@tzarc tzarc requested a review from a team July 16, 2020 06:42
@tzarc
Copy link
Member

tzarc commented Jul 16, 2020

Might need a rebase on top of latest develop -- there are a lot of changes that aren't yours.

@sevanteri
Copy link
Contributor Author

@tzarc Done. I also removed the commits that were part of my other PR so that this is smaller and mergable without the other PR.

@tzarc tzarc merged commit 85654d6 into qmk:develop Jul 16, 2020
noroadsleft pushed a commit that referenced this pull request Jul 18, 2020
* Add change log

* Change combo index from uint8_t to uint16_t
noroadsleft pushed a commit that referenced this pull request Jul 26, 2020
* Add change log

* Change combo index from uint8_t to uint16_t
noroadsleft pushed a commit that referenced this pull request Jul 31, 2020
* Add change log

* Change combo index from uint8_t to uint16_t
noroadsleft pushed a commit that referenced this pull request Aug 11, 2020
* Add change log

* Change combo index from uint8_t to uint16_t
noroadsleft pushed a commit that referenced this pull request Aug 27, 2020
* Add change log

* Change combo index from uint8_t to uint16_t
noroadsleft pushed a commit that referenced this pull request Aug 29, 2020
* Add change log

* Change combo index from uint8_t to uint16_t
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
* Add change log

* Change combo index from uint8_t to uint16_t
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Sep 30, 2020
* Add change log

* Change combo index from uint8_t to uint16_t
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
* Add change log

* Change combo index from uint8_t to uint16_t
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Add change log

* Change combo index from uint8_t to uint16_t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Changes that need to wait for a version increment core enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants