Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update Japanese translation of newbs_building_firmware.md. #9810

Merged
merged 3 commits into from
Aug 1, 2020
Merged

[Docs] Update Japanese translation of newbs_building_firmware.md. #9810

merged 3 commits into from
Aug 1, 2020

Conversation

shelaf
Copy link
Contributor

@shelaf shelaf commented Jul 24, 2020

Description

Japanese documentation update.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

tag: @mtei

@mtei
Copy link
Contributor

mtei commented Jul 24, 2020

@umi-umi @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

mtei
mtei approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@mtei mtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点以外は、問題なさそうです。

docs/ja/newbs_building_firmware.md Outdated Show resolved Hide resolved
@mtei mtei requested a review from a team July 30, 2020 14:30
@shelaf @mtei
Apply suggestions from code review
fc8fffa 
Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com>
@mtei
Copy link
Contributor

mtei commented Jul 31, 2020

I think this is ready to merge.

@noroadsleft noroadsleft merged commit 28c7802 into qmk:master Aug 1, 2020
@noroadsleft
Copy link
Member

ありがとうございました！

@shelaf shelaf deleted the ja_newbs_building_firmware branch August 1, 2020 01:01
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@shelaf @nicocesar
[Docs] Update Japanese translation of newbs_building_firmware.md. (qm…
e13b005 
…k#9810)

* Update Japanese translation of newbs_building_firmware.md.

* fix original document version.

* Apply suggestions from code review
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@shelaf
[Docs] Update Japanese translation of newbs_building_firmware.md. (qm…
29ceaec 
…k#9810)

* Update Japanese translation of newbs_building_firmware.md.

* fix original document version.

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtei mtei mtei approved these changes

@s-show s-show s-show approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shelaf @mtei @noroadsleft @s-show