Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR checklist document. #9913

Merged
merged 5 commits into from
Aug 6, 2020
Merged

Add PR checklist document. #9913

merged 5 commits into from
Aug 6, 2020

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Aug 2, 2020

Description

Adds a new PR checklist document to simplify ambiguities when asking for changes, as well as providing some consistency.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team August 2, 2020 02:20
noroadsleft
noroadsleft requested changes Aug 4, 2020
View reviewed changes
docs/pr_checklist.md Outdated Show resolved Hide resolved
@noroadsleft noroadsleft requested a review from a team August 4, 2020 00:32
@tzarc @noroadsleft
Update docs/pr_checklist.md
5c69a16 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@tzarc tzarc requested a review from noroadsleft August 4, 2020 01:03
noroadsleft
noroadsleft approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from a team August 4, 2020 05:01
fauxpark
fauxpark requested changes Aug 4, 2020
View reviewed changes
docs/pr_checklist.md Show resolved Hide resolved
fauxpark
fauxpark requested changes Aug 4, 2020
View reviewed changes
docs/pr_checklist.md Outdated Show resolved Hide resolved
@tzarc @fauxpark
Apply suggestions from code review
f9082a9 
Co-authored-by: Ryan <fauxpark@gmail.com>
@tzarc tzarc requested review from fauxpark and a team August 4, 2020 05:56
@Didel

This comment has been minimized.

Sign in to view
nooges
nooges reviewed Aug 4, 2020
View reviewed changes
docs/pr_checklist.md Outdated Show resolved Hide resolved
@fauxpark fauxpark mentioned this pull request Aug 5, 2020
Merged
13 tasks
@tzarc tzarc merged commit 8dc2502 into qmk:master Aug 6, 2020
@tzarc tzarc deleted the pr_checklist branch August 6, 2020 20:17
Didel
Didel reviewed Aug 7, 2020
View reviewed changes
Copy link
Contributor

@Didel Didel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad the comment wasn't entirely useless after all 👍🏻

fdawans pushed a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@tzarc @noroadsleft
@fauxpark @fdawans
Add PR checklist document. (qmk#9913)
461f414 
* Add PR checklist document.

* Update docs/pr_checklist.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Reword the lower/raise/adjust suggestion somewhat for clarity.

* Add suggestion from @Didel for coding conventions.

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
fdawans added a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@fdawans
Revert "Add PR checklist document. (qmk#9913)"
b38b13d 
This reverts commit 461f414.
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@tzarc @noroadsleft
@fauxpark @nicocesar
Add PR checklist document. (qmk#9913)
7dded63 
* Add PR checklist document.

* Update docs/pr_checklist.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Reword the lower/raise/adjust suggestion somewhat for clarity.

* Add suggestion from @Didel for coding conventions.

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
@tzarc @noroadsleft
@fauxpark @fcoury
Add PR checklist document. (qmk#9913)
e5e3f68 
* Add PR checklist document.

* Update docs/pr_checklist.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Reword the lower/raise/adjust suggestion somewhat for clarity.

* Add suggestion from @Didel for coding conventions.

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@tzarc @noroadsleft @fauxpark
Add PR checklist document. (qmk#9913)
4f3bee8 
* Add PR checklist document.

* Update docs/pr_checklist.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Reword the lower/raise/adjust suggestion somewhat for clarity.

* Add suggestion from @Didel for coding conventions.

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nooges nooges nooges left review comments

@Didel Didel Didel left review comments

@ridingqwerty ridingqwerty ridingqwerty left review comments

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tzarc @Didel @nooges @fauxpark @ridingqwerty @noroadsleft