LOGBACK-1326 Allow LayoutWrappingEncoder to have a parent of a type other than Appender #383
Conversation
…Appender`. This allow `LayoutWrappingEncoder` to be used within another `Encoder`. The introduction of `setParent(Appender)` in logback 1.2.1 caused an issue in downstream projects that allow a `LayoutWrappingEncoder` to be used within another `Encoder`. Specifically: logfellow/logstash-logback-encoder#232
philsttr
changed the title
|
Any chance this could be merged soon? |
|
It would be great to have someone from the qos-ch/logback team look into this PR! |
… 1.2.1+ See #232, [LOGBACK-1326](https://jira.qos.ch/browse/LOGBACK-1326) and logback [PR#383](qos-ch/logback#383)
|
Is there a reason this cannot be merged? |
|
Hi @ceki, could you please review? |
|
@ceki, Any updates on this? When will this be merged? Or specify any alternative for Masking Patterns with Logstash Json Encoder. |
|
@ceki can you please take a look at this? |
|
It's marked to be fixed for 1.3.0-apha5. |
|
Thanks, great news! |
|
Any idea when 1.3.0 will likely be released? |
|
Hi @ceki I appreciate it's quite a big job getting 1.3.0 GA released, and this didn't make the 1.3.0-alpha5, so is there a chance this could be in a 1.2.x release? |
logback-core/src/main/java/ch/qos/logback/core/encoder/LayoutWrappingEncoder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: RegalMedia <RegalMedia@users.noreply.github.com>
|
For those that have commented here, or given a thumbs up... please go vote on logback's JIRA tracker... https://jira.qos.ch/browse/LOGBACK-1326 I'm hoping to increase the visibility. I was disappointed to see logback 1.2.4 released recently without this fix. |
|
Fixed in 1.3.0-alpha6-SNAPSHOT and also in 1.2.5 which was released a few moments ago. |
|
Thanks so much @ceki ! |
|
Sorry for the delay in fixing this issue. |
See LOGBACK-1326
This allows
LayoutWrappingEncoderto be used within anotherEncoder.The introduction of
setParent(Appender)in logback 1.2.1 caused an issue in downstream projectsthat allow a
LayoutWrappingEncoderto be used within anotherEncoder.Specifically: logfellow/logstash-logback-encoder#232