Skip to content

Commit

Permalink
make sure the CI fails when pytest script fails (axolotl-ai-cloud#1669)
Browse files Browse the repository at this point in the history
* make sure the pytest script fails

* make sure the defaults come through for tests

* make sure tensorboard is loaded for test assertion
  • Loading branch information
winglian authored May 29, 2024
1 parent 49b967b commit fe650dd
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions cicd/cicd.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/bin/bash
set -e

pytest --ignore=tests/e2e/ /workspace/axolotl/tests/
pytest /workspace/axolotl/tests/e2e/patched/
Expand Down
4 changes: 2 additions & 2 deletions src/axolotl/utils/samplers/multipack.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ def __init__(
self.lengths = np.array(lengths, dtype=np.int32)
self.batch_max_len = batch_max_len
self.batch_size = batch_size
self.group_size = group_size
self.bin_size = bin_size
self.group_size = group_size if group_size is not None else 100_000
self.bin_size = bin_size if bin_size is not None else 200
self.drop_last = drop_last

self._efficiency = None
Expand Down
1 change: 1 addition & 0 deletions tests/e2e/patched/test_resume.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def test_resume_qlora_packed(self, temp_dir):
"save_steps": 10,
"save_total_limit": 5,
"max_steps": 40,
"use_tensorboard": True,
}
)
if is_torch_bf16_gpu_available():
Expand Down

0 comments on commit fe650dd

Please sign in to comment.