Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include annotations #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include annotations #1

wants to merge 1 commit into from

Conversation

fxchen
Copy link

@fxchen fxchen commented Jun 27, 2020

Hey there Bob!

I've been a fan for years and recommended a few of your articles to friends.

When I read your article I found myself appreciating the detail you put into your notebook! I thought I'd share a small amendment I typically like to use with complex graphs to annotate training periods (to understand causation).

I added two sample annotations you had mentioned in your post (marathon training and bulking) so I thought I'd share back to your code base. Feel free to do with this what you'd like.

See the attachment for what this looks like on the figure
image

@btroia
Copy link
Member

btroia commented Jun 27, 2020

Thanks for the pull request! Yes, optional annotations would be a nice addition but I am leaning towards a slightly different way of implementing them to supplement the body comp data (to maintain a minimalistic look and feel)

  1. Annotations should have start/end dates (if something happened on a single day, these values would be the same)
  2. Below the primary chart/x-axis (or as a separate chart), display annotations in more of a Gantt style, i.e.:

daterange-annotations

I was planning on this type of chart to visualize the different measurement tools I have used over the years and their date ranges.

Another way (not as clean, IMO) is to add colored areas for each annotation:

stock-annotations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants