cleanup arrays if the last value, which is not undefined,

gets removed from it
quantizor · Nov 9, 2021 · dcc63d9 · dcc63d9
1 parent b9cc253
commit dcc63d9
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/.changeset/fair-students-fix.md b/.changeset/fair-students-fix.md
@@ -0,0 +1,6 @@
+---
+'formik': patch
+'formik-native': patch
+---
+
+Fixes array fields not beeing cleanup up properly if the get deleted
diff --git a/packages/formik/src/FieldArray.tsx b/packages/formik/src/FieldArray.tsx
@@ -288,7 +288,12 @@ class FieldArrayInner<Values = {}> extends React.Component<
         if (isFunction(copy.splice)) {
           copy.splice(index, 1);
         }
-        return copy;
+        // if the array only includes undefined values we have to return an empty array
+        return isFunction(copy.every)
+          ? copy.every(v => v === undefined)
+            ? []
+            : copy
+          : copy;
       },
       true,
       true

diff --git a/packages/formik/test/FieldArray.test.tsx b/packages/formik/test/FieldArray.test.tsx
@@ -382,6 +382,14 @@ describe('<FieldArray />', () => {
       expect(formikBag.errors.friends).toEqual(undefined);
       expect(formikBag.touched.friends).toEqual(undefined);
     });
+    it('should clean up errors', () => {
+      act(() => {
+        formikBag.setFieldError('friends.1', 'Field error');
+        arrayHelpers.remove(1);
+      });
+
+      expect(formikBag.errors.friends).toEqual(undefined);
+    });
   });
 
   describe('given array-like object representing errors', () => {