Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306 : I believe this fixes https://www.npmjs.com/advisories/1219 if
options.disableParsingRawHTML
is set.NOTE: This does not handle script elements, etc., that may be rendered
when
options.disableParsingRawHTML
is not enabled. We might be able touse something like
dompurify
tosolve that case?
According to https://owasp.org/www-community/xss-filter-evasion-cheatsheet ,
the dangerous
javascript:
protocol can contain some whitespacecharacters and still be vulnerable, and sometimes when used in
conjunction with images, some other special characters like ` or <
before the javascript: protocol can also leave a url vulnerable.
This change re-adds the sanitiation logic removed in 9c6c782 , and also
adds the vbscript/data handling from github.com/ariabuckles/simple-markdown/pull/63
Test plan:
Add tests and run
npm test