Remove usage of deprecated native-image mojo from amazon-lambda integration tests #11659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
approved these changes
Aug 27, 2020
|
You don't have to add it to amazon-lambda. I was just using that as an easy way to reproduce the problem. |
geoand
approved these changes
Aug 27, 2020
Most of the integration tests use the old way of configuring native - which likely the problem manifested for you some of the times. I think you mentioned that the problem did not occur when you used codestarts? That fits this theory perfectly |
…lambda integration tests
|
Merging this. The tests have all passed except the Windows Java 11 JVM one and the Data 4 Native tests, which is failing with the issue reported at #11711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11655
@patriot1burke, does this work?
We will have to do similar changes for the other integration tests, but for now I think this should get @patriot1burke past the issue he's running into.