Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy fetch associations with Hibernate Reactive #15818

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Lazy fetch associations with Hibernate Reactive #15818

merged 2 commits into from
Mar 17, 2021

Conversation

DavideD
Copy link
Contributor

@DavideD DavideD commented Mar 17, 2021 •
edited
Loading

Fetch of lazy associations after a find

Fixes #15814

@DavideD
[quarkusio#15814] Set enableCollectionInDefaultFetchGroup to true for HR
76072c5 
The default for ORM is false, but when we create the SessionFactory
for Hibernate Reactive this value has to be true.

For more details, see:
hibernate/hibernate-reactive#663
@DavideD
[quarkusio#15814] Test lazy fetching with Hibernate Reactive
bf9e86d
@Sanne Sanne self-requested a review March 17, 2021 17:29
@DavideD
Copy link
Contributor Author

DavideD commented Mar 17, 2021

I've added the test only for PostgreSQL, let me know if I should add them for the other dbs as well

@Sanne
Copy link
Member

Sanne commented Mar 17, 2021

Ok so you're enabling the flag only for Hibernate Reactive.

That's good as I'd like to backport this - but let's also create a follow-up which sets the flag for ORM blocking as well in the next version.

@Sanne Sanne added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Mar 17, 2021
@DavideD DavideD changed the title 15814 lazy fetch 15814 lazy fetch associations with Hibernate Reactive Mar 17, 2021
This was referenced Mar 17, 2021
Closed
Closed
@DavideD
Copy link
Contributor Author

DavideD commented Mar 17, 2021

That's good as I'd like to backport this - but let's also create a follow-up which sets the flag for ORM blocking as well in the next version.

I've created this: #15819

@gsmet gsmet changed the title 15814 lazy fetch associations with Hibernate Reactive Lazy fetch associations with Hibernate Reactive Mar 17, 2021
@Sanne Sanne merged commit 280967a into quarkusio:main Mar 17, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 17, 2021
@gavinking
Copy link

Thanks Davide.

@gsmet gsmet modified the milestones: 1.14 - main, 1.13.0.Final Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Sanne approved these changes

Assignees
No one assigned
Labels
area/hibernate-reactive area/persistence OBSOLETE, DO NOT USE triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.13.0.Final
Development

Successfully merging this pull request may close these issues.

For Hibernate Reactive enableCollectionInDefaultFetchGroup must be set to true
4 participants
@DavideD @Sanne @gavinking @gsmet