Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute - few micro-optimizations #22604

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Qute - few micro-optimizations #22604

merged 1 commit into from
Jan 4, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 4, 2022

  • get rid of LinkedList
  • cache hashCode in MemberKey used in ReflectionValueResolver
  • use CompletedStage where possible
  • IfSectionHelper refactoring

@mkouba
Qute - few micro-optimizations
b335c8f 
- get rid of LinkedList
- cache hashCode in MemberKey used in ReflectionValueResolver
- use CompletedStage where possible
- IfSectionHelper refactoring
@mkouba mkouba added this to the 2.7 - main milestone Jan 4, 2022
@mkouba mkouba added the area/qute The template engine label Jan 4, 2022
gsmet
gsmet approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 4, 2022

Failing Jobs - Building b335c8f

Status Name Step Failures Logs Raw logs
✖ Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleNamedInjectionDevModeTest.main line 21 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@mkouba mkouba merged commit 15ed504 into quarkusio:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/qute The template engine
Projects
None yet
Milestone
2.7.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@mkouba @gsmet