Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - fix disposer method resolution #23333

Merged
merged 1 commit into from
Feb 2, 2022
Merged

ArC - fix disposer method resolution #23333

merged 1 commit into from
Feb 2, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 1, 2022

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Feb 1, 2022
@mkouba mkouba added this to the 2.8 - main milestone Feb 1, 2022
manovotn
manovotn approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 1, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 1, 2022 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 26f64ca

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-classic/resteasy/deployment 
! Skipped: extensions/agroal/deployment extensions/apicurio-registry-avro/deployment extensions/avro/deployment and 281 more

📦 extensions/resteasy-classic/resteasy/deployment

✖ io.quarkus.resteasy.test.IncompletePostTestCase.testIncompleteWrite line 36 - More details - Source on GitHub

java.net.ConnectException: Connection refused: connect
	at java.base/java.net.PlainSocketImpl.connect0(Native Method)
	at java.base/java.net.PlainSocketImpl.socketConnect(PlainSocketImpl.java:101)

@geoand geoand merged commit e433be9 into quarkusio:main Feb 2, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 2, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.1.Final Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
2.7.1.Final
Development

Successfully merging this pull request may close these issues.

A @Disposes @Named method doesn't work / is not invoked
5 participants
@mkouba @Ladicek @manovotn @gsmet @geoand