Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch for index.html creation #43586

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Sep 30, 2024

Fix #40829

In this PR:

  • Added a watch for index.html
  • Make sure to always watch META-INF for changes
  • Clean up some stacktraces that print in the log
  • Make the logo in the welcome page clickable, so when you created your own index.html, you can click the logo to re-try

index

@geoand
Copy link
Contributor

geoand commented Sep 30, 2024

Nice!

@phillip-kruger I think these changes warrant separate commits, WDYT?

@phillip-kruger
Copy link
Member Author

So this problem was always there. In a Quarkus 3.8 if you remove the generated index.html. Then Build and start in dev mode, then add a index.html, you will get the same error. The only difference is in 3.8 you get the 404 page and currently you get the welcome page

@phillip-kruger
Copy link
Member Author

@geoand I don't really have an opinion on the separate commits. We usually squash all commits. They are all related to the fix, but I am happy to redo with more commits.

@geoand
Copy link
Contributor

geoand commented Sep 30, 2024

Yeah, I think that since you are fixing multiple partially unrelated things, it makes sense to split into separate commits.

@phillip-kruger
Copy link
Member Author

@geoand - ok split into 3 commits.

@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 30, 2024
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 30, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 711d22b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 9bba606 into quarkusio:main Sep 30, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Sep 30, 2024
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dynamic default page can't handle I add a index.html file
3 participants