-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch for index.html creation #43586
Conversation
Nice! @phillip-kruger I think these changes warrant separate commits, WDYT? |
So this problem was always there. In a Quarkus 3.8 if you remove the generated index.html. Then Build and start in dev mode, then add a index.html, you will get the same error. The only difference is in 3.8 you get the 404 page and currently you get the welcome page |
@geoand I don't really have an opinion on the separate commits. We usually squash all commits. They are all related to the fix, but I am happy to redo with more commits. |
Yeah, I think that since you are fixing multiple partially unrelated things, it makes sense to split into separate commits. |
19162fa
to
5811e26
Compare
5811e26
to
711d22b
Compare
@geoand - ok split into 3 commits. |
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
Fix #40829
In this PR: