Reuse compiler configuration in quarkus:dev

[gastaldi]

Fixes #6881

[gastaldi]

@DenisKipchakbaev can you build this PR locally and confirm that it works for you?

[deniswed]

@DenisKipchakbaev can you build this PR locally and confirm that it works for you?

yes, I'll try it. Thanks!

[kipcd]

I've tried it and it seems OK!
What did I do:

• Cloned your fork:
  git clone git@github.com:gastaldi/quarkus.git
• Built and installed it on local maven repository:
  mvn clean install -DskipTests
• Changed pom.xml, put 999-VERSION for quarkus-maven-plugin and platform:

<quarkus-plugin.version>999-SNAPSHOT</quarkus-plugin.version>
<quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
<quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
<quarkus.platform.version>999-SNAPSHOT</quarkus.platform.version> 

Also used quarkus-bom instead of quarkus-universe-bom, because it's not building with this version.

• Run mvn clean quarkus:dev several times and every time it started successfully.

Seems OK to me

[gastaldi]

@DenisKipchakbaev yes, thank you very much for verifying.

BTW you can also use hub from hub.github.com and do a hub pr checkout 6894 to checkout and build the PR locally.

[ghost]

I also did the same and it is working for me also. Thanks @gastaldi! Good job!

[gastaldi]

Thank you @wedamartinez! @gsmet feel free to review the PR when possible

[gastaldi]

Now that I think better, the best is to leave as is and remove the todo message. Setting an explicit source/target will have a different behavior than using mvn compile,therefore it is correct to assume an empty configuration here. Need to check on multimodule projects though Em Qui, 30 de jan de 2020 16:17, Guillaume Smet <notifications@github.com> escreveu:

…

***@***.**** commented on this pull request. ------------------------------ In devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java <#6894 (comment)>: > @@ -266,13 +266,18 @@ public void execute() throws MojoFailureException, MojoExecutionException { if (plugin == null) { throw new MojoExecutionException("Failed to locate " + key + " among the project plugins"); } + Xpp3Dom configuration = (Xpp3Dom) plugin.getConfiguration(); + if (configuration == null) { + // TODO: Set sources and target to supported version Should we keep this TODO or do it right away? I think I would go with 8 for now and upgrade to 11 as soon as we drop 8. WDYT? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6894?email_source=notifications&email_token=AAANG5P6BTVCVZBTADDZQ43RAMRTFA5CNFSM4KNYYMYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCTWP6OQ#pullrequestreview-351076154>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAANG5J57IG3MRXDCNMXJKLRAMRTFANCNFSM4KNYYMYA> .

[geoand]

Nice work!

I agree we probably shouldn't set the source/target

[gsmet]

OK, let's try to get this in by tomorrow. I would really like to have that one in the Alpha1 we will release early next week.

[gastaldi]

I removed the TODO message. It should be ok now

[gsmet]

Woot!

[kipcd]

Thank you guys for a great job!