Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blocker issues detected with SonarCloud #7170

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Fix blocker issues detected with SonarCloud #7170

merged 1 commit into from
Feb 13, 2020

Conversation

gwenneg
Copy link
Member

@gwenneg gwenneg commented Feb 12, 2020 •
edited
Loading

Review this PR with the Hide whitespace changes option enabled, it will be much shorter.

gsmet
gsmet approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks.

Let's wait for CI.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 12, 2020
@gsmet gsmet merged commit 9f47cc5 into quarkusio:master Feb 13, 2020
@gwenneg gwenneg deleted the sonarqube-blockers branch February 13, 2020 10:07
@gwenneg gwenneg added this to the 1.3.0 milestone Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/maven area/scala area/scheduler area/security area/testing area/undertow triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.3.0.Alpha2
Development

Successfully merging this pull request may close these issues.
3 participants
@gwenneg @gastaldi @gsmet