Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(ui): add unit testing boilerplate and first tests #12047

Merged
merged 58 commits into from
Jan 31, 2022

Conversation

Evertvdw
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Testing!

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Copy link
Member

@IlCallo IlCallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave a first brief look and left some comments, will need to check this more in deep, but of course great work :)

ui/test/cypress/plugins/unit.js Outdated Show resolved Hide resolved
ui/test/cypress/support/commands.d.ts Show resolved Hide resolved
ui/test/cypress/helpers/create-spec.js Show resolved Hide resolved
@rstoenescu
Copy link
Member

Awesome! Looking forward to merge this after comments above are resolved.

Evertvdw and others added 28 commits January 26, 2022 21:06
(chore): add list of components prioritized
@IlCallo
Copy link
Member

IlCallo commented Jan 26, 2022

There is a weird problem with a faulty version of Cypress AE I published with the wrong name some months ago, and which apparently I'm not able to unpublish
This happens since we don't have a committed yarn.lock

@rstoenescu if you have permits, could you remove this version?
Seems like the - instead of . of all other versions is making people land on that one instead of newer beta releases

Anyway, since it was due some weeks ago, I directly released Cypress AE v4 as stable and used that one instead :)


I had to rebase on latest changes and adapt it to the externalization of vue and vue-router
I also added a yarn test:unit:ci for when we'll need to run it on GH pipeline
I ignored screenshots and videos folders since we don't want to commit those

Everything seems to run pretty smoothly, except a test into QSelect which is failing and the snapshots images which appear to not match anymore, as new ones are created into a different folder now.
@Evertvdw can you check out those 2 things?

@IlCallo IlCallo changed the title Add unit testing boilerplate and first components tests(ui): add unit testing boilerplate and first tests Jan 31, 2022
@IlCallo IlCallo merged commit 0542537 into quasarframework:dev Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants