feat(create-quasar): PNPM support #13615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's annoying to use rollup as a separate dep when it's deeply related to Vite. Adding this supress the warning on both apps that are using app-vite, and app-vite itself.
We are not directly using it in app-vite, so we can move it to devland. This helps to avoid missing peer deep errors/warnings from autoprefixer, which is installed on the default template, and is basically required. Existing apps will not be affected because Vite also ships postcss as a dependency.
15 tasks
IlCallo
reviewed
Sep 9, 2022
IlCallo
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)Other information:
shamefully-hoist=trueis for allowing app code to access dependencies in@quasar/app-*packages. One example would be@quasar/fastclick, which is used for iOS on PWA and Cordova. We inject this into auto-generated entry files, which are actually part of the app, so it will not be able to access the dependency defined in@quasar/app-*packages and will result in errors. We can choose to make it a peer dependency of@quasar/app-*packages and make it part of the starter kit. But, since that's not the only thing, we would be making the starter kits confusing and bloated, and they will be harder to update/manage, if it becomes not needed, we can't simply remove it, etc.For app-webpack there are lots of packages, so I don't see really see hope in a "shamefully-hoist-less" app-webpack.
For app-vite however, if I am not missing something, the only dependency with a runtime reference isThere are also@quasar/fastclick, so we can decide to move it to devland to be able to go "shamefully-hoist-less".express,compress, etc. and their respective@types/*packages too. So, we would need to go on a longer route, which is probably not a good idea, at least for now.Nuxt is also doing
shamefully-hoist=true, in fact, their starter kit only hasnuxtas a dev dependency, the rest including vue and vue-router is shared(not using exact pins). It would have at least been a problem in terms of import suggestions(like we had in #9235), but that's not a problem because they offer auto-imports.strict-peer-dependencies=falseis for avoiding the need for installing internal libraries like webpack, vite, etc. on devland. Installing webpack, vite, etc. loaders/plugins start enforcing this, so it's annoying without any real benefit at the app level for a framework like this IMO.Needs these for full PNPM support experience:
npm run xoryarn x" should also cover PNPM. Ideally, we should only display the instructions for the package manager the user is using.