Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill ffmpeg process on finish up if enabled #122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yvd
Copy link

@yvd yvd commented Jun 26, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

Added an option to kill the ffmpeg process in the finish_up phase. Useful when using an input source as camera

Why?

Need to deallocate input source (camera) programatically once the stream is finished, so that it can be used again.

Example Usage

video = ffmpeg_streaming.input("/dev/video0", capture=True)
hls = video.hls(Formats.h264(), kill_process_on_exit=True)

// Now we can do
hls.finish_up() // will stop the ffmpeg process and free the attached camera


#### To Do

- [ ] Create tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant