Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement xtypes using the newer version of go/types #398

Closed
quasilyte opened this issue Aug 28, 2022 · 0 comments · Fixed by #399
Closed

Re-implement xtypes using the newer version of go/types #398

quasilyte opened this issue Aug 28, 2022 · 0 comments · Fixed by #399
Assignees

Comments

@quasilyte
Copy link
Owner

See golangci/golangci-lint#3136
See go-critic/go-critic#1253

The xtypes package is a form of a hard copy of the go/types package with some types identity rules being overwritten.
Since Go type system is changed with generics, it'll be easier to re-apply the changes on top of the newest version of stdlib go/types package.

Note that we may need to do this again in the future: there is a chance that generics will evolve over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant