Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules.go: add context.TODO #119

Merged
merged 1 commit into from
Nov 3, 2020
Merged

rules.go: add context.TODO #119

merged 1 commit into from
Nov 3, 2020

Conversation

cristaloleg
Copy link
Collaborator

@cristaloleg cristaloleg commented Nov 3, 2020

// TODO returns a non-nil, empty Context. Code should use context.TODO when
// it's unclear which Context to use or it is not yet available (because the
// surrounding function has not yet been extended to accept a Context
// parameter). TODO is recognized by static analysis tools that determine
// whether Contexts are propagated correctly in a program.
func TODO() Context {
	return todo
}

But last sentence was removed from the documentation in https://go-review.googlesource.com/c/go/+/130876/

Also issues golang/lint#227 & golang/go#16742

@quasilyte quasilyte merged commit 8c1d690 into master Nov 3, 2020
@quasilyte quasilyte deleted the context-todo branch November 3, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants