ruleguard: fix interpolation of vars with common prefix #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If pattern had variables where one of them is a prefix of another, there was a chance of incorrect results. This change makes renderMessage() sort keys and interpolate longer var names first, so we avoid that risk. Scratch slice is used to do the sorting, so no extra allocations is added. As successfull matching is far less frequent than a failed (or rejected) match, sorting should not affect the performance. Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
cristaloleg
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pattern had variables where one of them is a prefix of another,
there was a chance of incorrect results.
This change makes renderMessage() sort keys and interpolate longer
var names first, so we avoid that risk.
Scratch slice is used to do the sorting, so no extra allocations
is added. As successfull matching is far less frequent than
a failed (or rejected) match, sorting should not affect the performance.
Signed-off-by: Iskander Sharipov quasilyte@gmail.com