Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bad defer unlock #131

Merged
merged 3 commits into from
Dec 3, 2020
Merged

add bad defer unlock #131

merged 3 commits into from
Dec 3, 2020

Conversation

cristaloleg
Copy link
Collaborator

@cristaloleg cristaloleg commented Dec 3, 2020 •
edited
Loading 

mu.RLock()
defer mu.Rlock() // <- bad one

quasilyte
quasilyte reviewed Dec 3, 2020
View reviewed changes
rules.go Outdated Show resolved Hide resolved
quasilyte
quasilyte approved these changes Dec 3, 2020
View reviewed changes
Copy link
Owner

@quasilyte quasilyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@quasilyte quasilyte merged commit d09d63c into master Dec 3, 2020
@quasilyte quasilyte deleted the add-bad-defer-lock branch December 3, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasilyte quasilyte quasilyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristaloleg @quasilyte