ruleguard: add loaded package deps to cache #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imagine that we import "dsl" from one file. Any importer would also load "dsl/types" package since it's "dsl" package dependency. So we would have both "dsl" and "dsl/types" packages loaded. Then other file imports "dsl" and "dsl/types" directly. We load both of them, but only "dsl" is cached, so we load "dsl/types" again. This leads to 2 versions of "dsl/types" (same content, different addresses) and weird issues during the typechecking. To avoid that, this patch adds all `Complete()` dependencies of loaded (imported) package to the cache. With that change, we would load "dsl/types" only once. Fixes #193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine that we import "dsl" from one file.
Any importer would also load "dsl/types" package since it's "dsl"
package dependency. So we would have both "dsl" and "dsl/types"
packages loaded.
Then other file imports "dsl" and "dsl/types" directly.
We load both of them, but only "dsl" is cached, so we load "dsl/types" again.
This leads to 2 versions of "dsl/types" (same content, different addresses)
and weird issues during the typechecking.
To avoid that, this patch adds all
Complete()dependenciesof loaded (imported) package to the cache. With that change,
we would load "dsl/types" only once.
Fixes #193