Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruleguard: continue pattern matching for multi-match patterns #340

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

quasilyte
Copy link
Owner

This is probably a temporary and sub-optimal solution, but
it should do for now.

Since matches are much more rare than pattern misses,
we do the check under the matched condition.
Extra condition shouldn't make anything measurably slower there.

Fixes #339

This is probably a temporary and sub-optimal solution, but
it should do for now.

Since matches are much more rare than pattern misses,
we do the check under the `matched` condition.
Extra condition shouldn't make anything measurably slower there.

Fixes #339
@quasilyte quasilyte merged commit 9b8154c into master Jan 2, 2022
@quasilyte quasilyte deleted the quasilyte/fix_339 branch January 2, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doesn't match already declared in previous expression variable in new expression
1 participant