dsl/fluent: improve Var.Type doc #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #80 Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
|
@sebastien-rosset please take a look. |
Thanks! I am looking now. |
| // but for a function expression itself it's a *types.Signature. | ||
| // | ||
| // Suppose we have a `a.b()` expression: | ||
| // `$x()` m["x"].Type is `a.b` function type |
There was a problem hiding this comment.
ok, that's great. I'm trying to understand what the Where argument value is supposed to be in the case of a function type. Is it the output of reflect.TypeOf($x).String()? That does not seem to work.
For example:
runtime.GC()
fmt.Printf("Type: %v\n", reflect.TypeOf(runtime.GC)) // output is `func()`How would we write m["x"].Type.Is(...)? If I type the rule below, the parser complains about parse type expr: can't convert func() type expression
m.Match(`$x($y)`).Where(m["x"].Type.Is("func()"))There was a problem hiding this comment.
Now I remember that Is() method doesn't implement function types matching. Fixed in #82.
See tests for some examples.
There was a problem hiding this comment.
ah ok, thank you!
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80
Signed-off-by: Iskander Sharipov quasilyte@gmail.com