Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aquilon 1.12.58: /system/archetype/os in object template has the wrong type #93

Closed
jouvin opened this issue Jun 4, 2018 · 2 comments
Closed

Aquilon 1.12.58: /system/archetype/os in object template has the wrong type #93

jouvin opened this issue Jun 4, 2018 · 2 comments

Comments

@jouvin
Copy link
Contributor

jouvin commented Jun 4, 2018 •
edited
Loading

In Aquilon 1.12.58, the broker still generate /system/archetype/os as a string according to the old schema. It was changed to a dict one year ago for the reasons explained in quattor/template-library-core#142. The broker should adapt to the new schema, potentially with an option to ease the transition at MS.

This is required for the template library support in Aquilon (see quattor/template-library-core#177). This is a subissue for #90.
jouvin added a commit to jouvin/aquilon that referenced this issue Jun 4, 2018
@jouvin
Export archetype/os as a dict in hostdata template
76660a0 
- Requires archetype_os_dict=true in aqd.conf (default: false)
- Required for template libary >= 17.7.0 support

Fixes quattor#93

Change-Id: Ibfb52dc616209dfd892449e572f95499f4ee6737
@jouvin jouvin mentioned this issue Jun 4, 2018
Closed
@ned21
Copy link
Contributor

ned21 commented Jun 4, 2018

hmm.. When quattor/template-library-core#142 was introduced it was explicitly called out that this did not require a change to aquilon because this was set in templates. Now it appears I wasn't aware that @jrha was using an older version of aqd which predates 3b82d80 that should have blocked
quattor/template-library-core#142 from being merged.

So I think we need to go back and undo #142.

@jrha
Copy link
Member

jrha commented Jun 5, 2018

I've opened quattor/template-library-core#181 to revert the breaking changes from quattor/template-library-core#142, reverting the entirety of quattor/template-library-core#142 would be overkill.

@jrha jrha mentioned this issue Jun 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ned21 @jrha @jouvin