Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: insert service data early in the object template #115

Open
wants to merge 1 commit into
base: upstream
Choose a base branch
from

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented Jul 17, 2018

This change allows service data to be available early in the object
template, before archetype/base is included. This makes possible to use
the service data for configuring any aspect of the host, cluster or
metacluster.

  • Includes a renaming of PlenaryServicexxxTopLevel classes into
    PlenaryServicexxxData

Fixes #109 (#109)

Host part has been tested at LAL but not the cluster/metacluster as we don't have such object for the moment and as I have no clue on how to run the unit tests.

@jouvin jouvin requested review from ned21, jrha and urbonegi July 17, 2018 13:41
@jouvin
Copy link
Contributor Author

jouvin commented Jul 17, 2018

The initial version of this PR doesn't intend to be complete/final. Its main goal is to illustrate a possible implementation. As agreed in #109, it should be merged as part of the planned changes to the object templates, not separately.

This change allows service data to be available early in the object
template, before archetype/base is included. This makes possible to use
the service data for configuring any aspect of the host, cluster or
metacluster.

- Includes a renaming of PlenaryServicexxxTopLevel classes into
PlenaryServicexxxData

Fixes quattor#109 (quattor#109)

Change-Id: Ife689ce3f59f057422e6c0f7f2098a5d1d44b9c6
@jouvin
Copy link
Contributor Author

jouvin commented Aug 16, 2018

@XaF Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant